Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-chip): DSW-000 hover and active styles are applied for disabled state #1348

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Mar 22, 2024

Describe your changes (can list changeset entries if preferable)

  • Fixes an issue raised by design that the hover and active styles are applied when disabled is true.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • If it is a component change, I have reviewed the Storybook preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • If there are visual test updates, I have reviewed them

Reviewer 2

  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Mar 22, 2024

🦋 Changeset detected

Latest commit: 87d7f57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@justeattakeaway/pie-chip Minor
pie-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe raoufswe marked this pull request as ready for review March 22, 2024 15:32
@raoufswe raoufswe requested review from a team as code owners March 22, 2024 15:32
@raoufswe raoufswe merged commit 782cd23 into main Mar 26, 2024
33 of 34 checks passed
@raoufswe raoufswe deleted the dsw-000-fix-chip-disabled-styles branch March 26, 2024 13:38
This was referenced Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants