Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pie-icons-react): DSW-1801 add entry points for individual icons #1347

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

xander-marjoram
Copy link
Contributor

@xander-marjoram xander-marjoram commented Mar 22, 2024

Describe your changes (can list changeset entries if preferable)

This allows icons to be imported individually like so:

import IconCheck from '@justeattakeaway/pie-icons-react/dist/IconCheck';

I tried without the /dist but it didn't work, and we couldn't really work out why because everything looked correctly configured.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code

Reviewer checklists (complete before approving)

Reviewer 1

  • No visual changes.

Reviewer 2

  • No visual changes.

Copy link

changeset-bot bot commented Mar 22, 2024

🦋 Changeset detected

Latest commit: 70311d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@justeattakeaway/pie-icons-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xander-marjoram xander-marjoram changed the title chore(pie-icons-react): DSW-1801 add entry points for individual reac… chore(pie-icons-react): DSW-1801 add entry points for individual icons Mar 22, 2024
@xander-marjoram
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshot has been published to npm!

Test the snapshot by updating your package.json with the newly-published version:

yarn up @justeattakeaway/[email protected]

@xander-marjoram
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshot has been published to npm!

Test the snapshot by updating your package.json with the newly-published version:

yarn up @justeattakeaway/[email protected]

@xander-marjoram xander-marjoram marked this pull request as ready for review March 27, 2024 14:30
@xander-marjoram xander-marjoram requested review from a team as code owners March 27, 2024 14:30
@xander-marjoram xander-marjoram merged commit 5d6c33e into main Mar 27, 2024
33 checks passed
@xander-marjoram xander-marjoram deleted the dsw-1801-pie-icons-react-exports branch March 27, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants