Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-docs): DSW-1639 add the chip docs #1330

Merged
merged 12 commits into from
Mar 22, 2024
Merged

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Mar 12, 2024

Describe your changes (can list changeset entries if preferable)

  • adds the overview section of the chip component

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • If it is a PIE Docs change, I have reviewed the Docs site preview

Reviewer checklists (complete before approving)

Reviewer 1

  • If it is a PIE Docs change, I have reviewed the PR preview

Reviewer 2

  • If it is a PIE Docs change, I have reviewed the PR preview

Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: b874e0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@justeattakeaway/pie-chip Minor
pie-docs Minor
pie-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe raoufswe force-pushed the dsw-1639-chip-overview-page branch from 9d7a290 to 1cbfaa8 Compare March 15, 2024 08:43
LTurns
LTurns previously approved these changes Mar 15, 2024
@raoufswe raoufswe marked this pull request as ready for review March 15, 2024 09:12
@raoufswe raoufswe requested review from a team as code owners March 15, 2024 09:12
LTurns
LTurns previously approved these changes Mar 15, 2024
@raoufswe raoufswe requested a review from LTurns March 15, 2024 10:41
Copy link
Contributor

@xander-marjoram xander-marjoram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update the PR title then all good!

@raoufswe raoufswe changed the title feat(pie-docs): DSW-1639 add the chip overview page feat(pie-docs): DSW-1639 add the chip docs Mar 15, 2024
@raoufswe raoufswe force-pushed the dsw-1639-chip-overview-page branch from 7f5ae55 to 07759d5 Compare March 22, 2024 09:08
@raoufswe raoufswe merged commit 74d8c16 into main Mar 22, 2024
36 checks passed
@raoufswe raoufswe deleted the dsw-1639-chip-overview-page branch March 22, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants