Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-docs): DSW-000 small tidy up of code pages in pie-docs #1195

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

LTurns
Copy link
Contributor

@LTurns LTurns commented Jan 19, 2024

Describe your changes (can list changeset entries if preferable)

[Removed] - peer dependency link in code pages
(we do not have a peer dependency link on the wiki, and this section currently links to aperture so it's confusing for consumers 👍 )

Also added link variants to storybook so they'll show on the code page and fixed a tiny bug in the resourceTable which was causing it to list all variants for numeric stepperinstead of just the correct variant (numeric stepper input / form)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • If it is a PIE Docs change, I have reviewed the Docs site preview
  • If it is a component change, I have reviewed the Storybook preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: 79978d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
pie-docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LTurns LTurns marked this pull request as ready for review January 23, 2024 08:27
@LTurns LTurns requested review from a team as code owners January 23, 2024 08:27
@LTurns LTurns merged commit 3acfdf8 into main Jan 23, 2024
34 checks passed
@LTurns LTurns deleted the dsw-000-small-pie-docs-tidyup branch January 23, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants