Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pie-monorepo): DSW-000 Update Turborepo #1628

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

siggerzz
Copy link
Contributor

@siggerzz siggerzz commented Jul 25, 2024


"pie-monorepo": minor

[Updated] - turbo version bump to 2.0.9

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code

@siggerzz siggerzz requested review from a team as code owners July 25, 2024 13:05
Copy link

changeset-bot bot commented Jul 25, 2024

🦋 Changeset detected

Latest commit: b8f8c37

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Lint PR Title] ❌ Failed.
The PR title should follow the same convention used for commits, e.g.:
type(scope): DSW-123 title where DSW-123 is the Jira ticket id or DSW-000 when one is not available.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Lint PR Title] ❌ Failed.
The PR title should follow the same convention used for commits, e.g.:
type(scope): DSW-123 title where DSW-123 is the Jira ticket id or DSW-000 when one is not available.

@siggerzz siggerzz changed the title Dsw 000 turborepo 2 electric boogaloo chore(pie-monorepo: DSW-000 Update Turborepo Jul 25, 2024
@siggerzz siggerzz changed the title chore(pie-monorepo: DSW-000 Update Turborepo chore(pie-monorepo): DSW-000 Update Turborepo Jul 25, 2024
@github-actions github-actions bot dismissed their stale review July 25, 2024 13:08

[Lint PR Title] ✅ All good!

@github-actions github-actions bot dismissed their stale review July 25, 2024 14:01

[Lint PR Title] ✅ All good!

@xander-marjoram xander-marjoram merged commit 994ddc7 into main Jul 26, 2024
55 of 56 checks passed
@xander-marjoram xander-marjoram deleted the dsw-000-turborepo-2-electric-boogaloo branch July 26, 2024 10:39
@@ -9,6 +9,7 @@
"engines": {
"node": "^16 || ^18 || ^20"
},
"packageManager": "[email protected]",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -52,9 +53,9 @@
"test:generate-routes": "turbo run test:generate-routes --filter=!pie-monorepo --token=${TURBO_TOKEN}",
"test:browsers-setup": "turbo run test:browsers-setup --filter=!pie-monorepo --token=${TURBO_TOKEN}",
"test:browsers": "cross-env-shell turbo run test:browsers --filter=!pie-monorepo --token=${TURBO_TOKEN}",
"test:browsers:ci": "cross-env-shell turbo run test:browsers:ci --filter=!pie-monorepo --token=${TURBO_TOKEN}",
"test:browsers:ci": "cross-env-shell turbo run test:browsers:ci --filter=!pie-monorepo --token=${TURBO_TOKEN} --env-mode=loose",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, Turborepo now only provides env variables to task that are defined in env - https://turbo.build/repo/docs/reference/configuration#env

This is because env vars should be considered as part of the cache hash. We should look to eventually update tasks to define the env vars they're dependant on, and remove this flag.

JoshuaNg2332 pushed a commit that referenced this pull request Jul 29, 2024
* attempt to fix env var v2

* chore(pie-monorepo): DSW-000 add Turborepo v2

* chore(pie-monorepo): DSW-000 add changeset

* chore(pie-monorepo): DSW-000 revert change

* chore(pie-monorepo): DSW-000 set env mode

---------

Co-authored-by: Ben Siggery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants