-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pie-monorepo): DSW-000 Update Turborepo #1628
Conversation
🦋 Changeset detectedLatest commit: b8f8c37 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Lint PR Title] ❌ Failed.
The PR title should follow the same convention used for commits, e.g.:
type(scope): DSW-123 title
where DSW-123
is the Jira ticket id or DSW-000
when one is not available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Lint PR Title] ❌ Failed.
The PR title should follow the same convention used for commits, e.g.:
type(scope): DSW-123 title
where DSW-123
is the Jira ticket id or DSW-000
when one is not available.
@@ -9,6 +9,7 @@ | |||
"engines": { | |||
"node": "^16 || ^18 || ^20" | |||
}, | |||
"packageManager": "[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turbo will now error if this isn't specified - https://turbo.build/repo/docs/reference/configuration#dangerouslydisablepackagemanagercheck
@@ -52,9 +53,9 @@ | |||
"test:generate-routes": "turbo run test:generate-routes --filter=!pie-monorepo --token=${TURBO_TOKEN}", | |||
"test:browsers-setup": "turbo run test:browsers-setup --filter=!pie-monorepo --token=${TURBO_TOKEN}", | |||
"test:browsers": "cross-env-shell turbo run test:browsers --filter=!pie-monorepo --token=${TURBO_TOKEN}", | |||
"test:browsers:ci": "cross-env-shell turbo run test:browsers:ci --filter=!pie-monorepo --token=${TURBO_TOKEN}", | |||
"test:browsers:ci": "cross-env-shell turbo run test:browsers:ci --filter=!pie-monorepo --token=${TURBO_TOKEN} --env-mode=loose", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, Turborepo now only provides env variables to task that are defined in env
- https://turbo.build/repo/docs/reference/configuration#env
This is because env vars should be considered as part of the cache hash. We should look to eventually update tasks to define the env vars they're dependant on, and remove this flag.
* attempt to fix env var v2 * chore(pie-monorepo): DSW-000 add Turborepo v2 * chore(pie-monorepo): DSW-000 add changeset * chore(pie-monorepo): DSW-000 revert change * chore(pie-monorepo): DSW-000 set env mode --------- Co-authored-by: Ben Siggery <[email protected]>
"pie-monorepo": minor
[Updated] - turbo version bump to 2.0.9
Author Checklist (complete before requesting a review)