Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-modal): DSW-2208 split leadingAction and supportingAction into multiple props #1626

Merged
merged 16 commits into from
Aug 1, 2024

Conversation

xander-marjoram
Copy link
Contributor

@xander-marjoram xander-marjoram commented Jul 24, 2024

Describe your changes (can list changeset entries if preferable)

  • [Changed] - Split leadingAction and supportingAction props into several new props
    • leadingAction -> leadingActionText and leadingActionVariant
    • supportingAction -> supportingActionText and supportingActionVariant
    • aria properties of leadingAction and supportingAction moved into root aria prop.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook / PIE Docs PR previews
  • I have reviewed the visual test changes
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1 - Maryia

  • I have reviewed the PIE Storybook / PIE Docs PR previews
  • I have reviewed the visual test changes

Reviewer 2 - @jamieomaguire

  • I have reviewed the PIE Storybook / PIE Docs PR previews
  • I have reviewed the visual test changes

Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: 96440a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@justeattakeaway/pie-cookie-banner Minor
@justeattakeaway/pie-modal Minor
pie-storybook Minor
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-react17 Patch
wc-react18 Patch
wc-vanilla Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xander-marjoram
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@xander-marjoram xander-marjoram marked this pull request as ready for review July 25, 2024 15:42
@xander-marjoram xander-marjoram requested review from a team as code owners July 25, 2024 15:42
@xander-marjoram xander-marjoram self-assigned this Jul 25, 2024
@xander-marjoram
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@xander-marjoram
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

dandel10n
dandel10n previously approved these changes Jul 29, 2024
@jamieomaguire jamieomaguire self-requested a review July 30, 2024 08:08
@jamieomaguire jamieomaguire merged commit 61fadf0 into main Aug 1, 2024
37 of 38 checks passed
@jamieomaguire jamieomaguire deleted the dsw-2208-modal-props branch August 1, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants