-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-modal): DSW-2208 split leadingAction and supportingAction into multiple props #1626
Conversation
🦋 Changeset detectedLatest commit: 96440a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/snapit |
Starting a new snapshot build. You can view the logs here. |
@xander-marjoram Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
194dda1
to
ac5d042
Compare
/snapit |
Starting a new snapshot build. You can view the logs here. |
@xander-marjoram Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
eeee35a
to
e4bd9ae
Compare
/snapit |
Starting a new snapshot build. You can view the logs here. |
@xander-marjoram Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
Describe your changes (can list changeset entries if preferable)
leadingAction
->leadingActionText
andleadingActionVariant
supportingAction
->supportingActionText
andsupportingActionVariant
leadingAction
andsupportingAction
moved into rootaria
prop.Author Checklist (complete before requesting a review)
PIE Storybook
/PIE Docs
PR previews/snapit
functionality to test my changes in a consuming applicationReviewer checklists (complete before approving)
Reviewer 1 - Maryia
PIE Storybook
/PIE Docs
PR previewsReviewer 2 - @jamieomaguire
PIE Storybook
/PIE Docs
PR previews