More changes from self-review

justeattakeaway · Jul 25, 2024 · 194dda1 · 194dda1
1 parent 972445c
commit 194dda1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/components/pie-cookie-banner/src/index.ts b/packages/components/pie-cookie-banner/src/index.ts
@@ -229,17 +229,16 @@ export class PieCookieBanner extends LitElement implements CookieBannerProps {
     }
 
     render () {
-        const leadingActionText = this._localiseText('preferencesManagement.cta.save.label');
         return html`
         <pie-modal
             .isOpen="${this._isModalOpen}"
             hasBackButton
             hasStackedActions
             isFullWidthBelowMid
             heading="${this._localiseText('preferencesManagement.title')}"
-            leadingActionText="${leadingActionText}"
+            leadingActionText="${this._localiseText('preferencesManagement.cta.save.label')}"
             leadingActionVariant="primary"
-            .aria=${{ leadingActionLabel: leadingActionText }}
+            .aria=${{ leadingActionLabel: this._localiseText('preferencesManagement.cta.save.ariaLabel') }}
             @pie-modal-leading-action-click="${this._handlePreferencesSaved}"
             @pie-modal-back="${this._displayCookieBanner}">
                 ${this.renderModalContent()}

diff --git a/packages/components/pie-modal/src/defs.ts b/packages/components/pie-modal/src/defs.ts
@@ -146,7 +146,7 @@ export const ON_MODAL_SUPPORTING_ACTION_CLICK = 'pie-modal-supporting-action-cli
 
 export type ModalActionType = 'leading' | 'supporting';
 
-export type DefaultProps = ComponentDefaultProps<ModalProps, keyof Omit<ModalProps, 'aria' | 'heading' | 'returnFocusAfterCloseSelector' | 'leadingActionText' | 'supportingActionText'>>;
+export type DefaultProps = ComponentDefaultProps<ModalProps, keyof Omit<ModalProps, 'aria' | 'heading' | 'leadingActionText' | 'supportingActionText' | 'returnFocusAfterCloseSelector'>>;
 
 export const defaultProps: DefaultProps = {
     hasBackButton: false,