Skip to content

Commit

Permalink
fix(pie-tag): DSW-000 address design feedback (#1226)
Browse files Browse the repository at this point in the history
* fix(pie-tag): DSW-000 address design feedback

* fix(pie-tag): DSW-000 address design feedback

---------

Co-authored-by: Ashley Watson-Nolan <[email protected]>
  • Loading branch information
raoufswe and ashleynolan authored Jan 29, 2024
1 parent 01a696d commit 04891f5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
7 changes: 7 additions & 0 deletions .changeset/wet-cobras-burn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@justeattakeaway/pie-tag": minor
---

[Changed] - The icon colour of blue-strong, green-strong, and red strong variants should be "content-inverse"
[Changed] - The icon and label colour of the yellow-subtle variant should be "content-default"

8 changes: 4 additions & 4 deletions packages/components/pie-tag/src/tag.scss
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@

&[isStrong] {
--tag-bg-color: var(--dt-color-support-info);
--tag-color: var(--dt-color-content-light);
--tag-color: var(--dt-color-content-inverse);
}
}

Expand All @@ -85,13 +85,13 @@

&[isStrong] {
--tag-bg-color: var(--dt-color-support-positive);
--tag-color: var(--dt-color-content-light);
--tag-color: var(--dt-color-content-inverse);
}
}

&[variant='yellow'] {
--tag-bg-color: var(--dt-color-support-warning-02);
--tag-color: var(--dt-color-content-dark);
--tag-color: var(--dt-color-content-default);

&[isStrong] {
--tag-bg-color: var(--dt-color-support-warning);
Expand All @@ -105,7 +105,7 @@

&[isStrong] {
--tag-bg-color: var(--dt-color-support-error);
--tag-color: var(--dt-color-content-light);
--tag-color: var(--dt-color-content-inverse);
}
}

Expand Down

0 comments on commit 04891f5

Please sign in to comment.