Adjust bulk request cleanup (#3)

* Adjust bulk request cleanup * Pint * Keep operation for at least one hour * Fix test
justbetter · Aug 28, 2024 · 05161c3 · 05161c3
1 parent 15fa683
commit 05161c3
Show file tree

Hide file tree

Showing 3 changed files with 116 additions and 12 deletions.
diff --git a/config/magento-async.php b/config/magento-async.php
@@ -3,6 +3,6 @@
 return [
     'queue' => 'default',
 
-    /* Cleanup requests after amount of time (hours) */
-    'cleanup' => 3,
+    /*  Always cleanup bulk requests after amount of time (hours) */
+    'cleanup' => 168,
 ];
diff --git a/src/Actions/CleanBulkRequests.php b/src/Actions/CleanBulkRequests.php
@@ -2,7 +2,10 @@
 
 namespace JustBetter\MagentoAsync\Actions;
 
+use Illuminate\Database\Eloquent\Builder;
 use JustBetter\MagentoAsync\Contracts\CleansBulkRequests;
+use JustBetter\MagentoAsync\Enums\OperationStatus;
+use JustBetter\MagentoAsync\Models\BulkOperation;
 use JustBetter\MagentoAsync\Models\BulkRequest;
 
 class CleanBulkRequests implements CleansBulkRequests
@@ -12,8 +15,21 @@ public function clean(): void
         /** @var int $cleanupHours */
         $cleanupHours = config('magento-async.cleanup');
 
+        // Delete completed statuses
+        BulkOperation::query()
+            ->where('status', '=', OperationStatus::Complete)
+            ->where('updated_at', '<', now()->subHour()) // Keep completed for at least one hour
+            ->delete();
+
         BulkRequest::query()
-            ->where('created_at', '<', now()->subHours($cleanupHours))
+            // Delete where there are no more operations
+            ->where(function (Builder $query): void {
+                $query
+                    ->whereDoesntHave('operations')
+                    ->where('created_at', '<', now()->subHour()); // Never delete within an hour
+            })
+            // Always delete after configured cleanup time
+            ->orWhere('created_at', '<', now()->subHours($cleanupHours))
             ->delete();
     }
 

diff --git a/tests/Actions/CleanBulkRequestsTest.php b/tests/Actions/CleanBulkRequestsTest.php
@@ -2,19 +2,21 @@
 
 namespace JustBetter\MagentoAsync\Tests\Actions;
 
+use Illuminate\Support\Carbon;
 use JustBetter\MagentoAsync\Actions\CleanBulkRequests;
+use JustBetter\MagentoAsync\Enums\OperationStatus;
 use JustBetter\MagentoAsync\Models\BulkRequest;
 use JustBetter\MagentoAsync\Tests\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
 
 class CleanBulkRequestsTest extends TestCase
 {
     #[Test]
-    public function it_deletes_request(): void
+    public function it_deletes_completed_operations(): void
     {
-        config()->set('magento-async.cleanup', 1);
-
-        BulkRequest::query()->create([
+        /** @var BulkRequest $request */
+        $request = BulkRequest::query()->create([
             'magento_connection' => '::magento-connection::',
             'store_code' => '::store-code::',
             'path' => '::path::',
@@ -24,22 +26,108 @@ public function it_deletes_request(): void
             'created_at' => now(),
         ]);
 
-        BulkRequest::query()->create([
+        $request->operations()->create([
+            'operation_id' => 1,
+            'status' => OperationStatus::Complete,
+            'updated_at' => now()->subHours(2),
+        ]);
+
+        $request->operations()->create([
+            'operation_id' => 2,
+            'status' => OperationStatus::Complete,
+        ]);
+
+        $request->operations()->create([
+            'operation_id' => 3,
+            'status' => OperationStatus::Open,
+        ]);
+
+        /** @var CleanBulkRequests $action */
+        $action = app(CleanBulkRequests::class);
+        $action->clean();
+
+        $this->assertEquals(2, $request->operations()->count());
+    }
+
+    /** @param array<string, mixed> $operations */
+    #[Test]
+    #[DataProvider('cases')]
+    public function it_deletes_request(Carbon $requestCreatedAt, array $operations, bool $shouldBeDeleted): void
+    {
+        config()->set('magento-async.cleanup', 2);
+
+        /** @var BulkRequest $request */
+        $request = BulkRequest::query()->create([
             'magento_connection' => '::magento-connection::',
             'store_code' => '::store-code::',
             'path' => '::path::',
-            'bulk_uuid' => '::bulk-uuid-2::',
+            'bulk_uuid' => '::bulk-uuid-1::',
             'request' => [],
             'response' => [],
-            'created_at' => now()->subHours(2),
+            'created_at' => $requestCreatedAt,
         ]);
 
+        foreach ($operations as $operation) {
+            $request->operations()->create($operation);
+        }
+
         /** @var CleanBulkRequests $action */
         $action = app(CleanBulkRequests::class);
         $action->clean();
 
-        $this->assertNotNull(BulkRequest::query()->firstWhere('bulk_uuid', '=', '::bulk-uuid-1::'));
-        $this->assertNull(BulkRequest::query()->firstWhere('bulk_uuid', '=', '::bulk-uuid-2::'));
+        $deleted = BulkRequest::query()->firstWhere('bulk_uuid', '=', '::bulk-uuid-1::') === null;
+        $this->assertEquals($shouldBeDeleted, $deleted);
+    }
+
+    /** @return array<string, mixed> */
+    public static function cases(): array
+    {
+        return [
+            'Pending operation' => [
+                'requestCreatedAt' => now(),
+                'operations' => [
+                    [
+                        'operation_id' => 1,
+                        'status' => null,
+                    ],
+                ],
+                'shouldBeDeleted' => false,
+            ],
+
+            'Completed operations' => [
+                'requestCreatedAt' => now()->subHours(2),
+                'operations' => [
+                    [
+                        'operation_id' => 1,
+                        'status' => OperationStatus::Complete,
+                        'updated_at' => now()->subHours(2),
+                    ],
+                ],
+                'shouldBeDeleted' => true,
+            ],
+
+            'Failed operations' => [
+                'requestCreatedAt' => now()->subHours(1),
+                'operations' => [
+                    [
+                        'operation_id' => 1,
+                        'status' => OperationStatus::RetriablyFailed,
+                    ],
+                ],
+                'shouldBeDeleted' => false,
+            ],
+
+            'Cleanup time' => [
+                'requestCreatedAt' => now()->subWeek(),
+                'operations' => [
+                    [
+                        'operation_id' => 1,
+                        'status' => OperationStatus::RetriablyFailed,
+                    ],
+                ],
+                'shouldBeDeleted' => true,
+            ],
 
+        ];
     }
 }