fix(connector): [CASHTOCODE] Populate error reason #7154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
2 tasks
deepanshu-iiitu
requested changes
Jan 31, 2025
| message: response.error_description, | ||
| reason: None, | ||
| message: response.error_description.clone(), | ||
| reason: Some(response.error_description.clone()), |
There was a problem hiding this comment.
Suggested change
| reason: Some(response.error_description.clone()), | |
| reason: Some(response.error_description), |
There was a problem hiding this comment.
I have resolved it, thanks
| message: error_data.error_description, | ||
| reason: None, | ||
| message: error_data.error_description.clone(), | ||
| reason: Some(error_data.error_description.clone()), |
There was a problem hiding this comment.
Suggested change
| reason: Some(error_data.error_description.clone()), | |
| reason: Some(error_data.error_description), |
There was a problem hiding this comment.
I have resolved it, thanks
deepanshu-iiitu
changed the title
deepanshu-iiitu
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Error message from cashtocode is now populated in error reason along with error message as well.
Additional Changes
Motivation and Context
Issue Link: #7155
How did you test it?
Cashtocode cannot be tested locally due to unavailability of credentials.
Checklist
cargo +nightly fmt --allcargo clippy