Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(users): remove force cookie for docker setup #6932

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

apoorvdixit88
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Users not able to login using local setup.
This PR removes force cookie option for docker setup.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #6931

How did you test it?

Tested locally with updated docker configs, and re run the container.
Screenshot 2024-12-23 at 12 40 17 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@apoorvdixit88 apoorvdixit88 self-assigned this Dec 24, 2024
@apoorvdixit88 apoorvdixit88 requested a review from a team as a code owner December 24, 2024 10:37
Copy link

Review changes with  SemanticDiff

@apoorvdixit88 apoorvdixit88 added C-bug Category: Bug A-users Area: Users labels Dec 24, 2024
@SanchithHegde SanchithHegde merged commit 5961878 into hotfix-2024.12.04.0 Dec 24, 2024
14 of 19 checks passed
@SanchithHegde SanchithHegde deleted the fix-cookie-bug-for-docker-setup branch December 24, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-users Area: Users C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants