Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wasm): fix feature dependencies in connector_configs crate for WASM builds #6832

Merged
merged 8 commits into from
Dec 23, 2024
Merged

fix(wasm): fix feature dependencies in connector_configs crate for WASM builds #6832

merged 8 commits into from
Dec 23, 2024

Conversation

srujanchikke
Copy link
Contributor

@srujanchikke srujanchikke commented Dec 12, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

fix connector configs for wasm build.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

fix connector configs for wasm build.

How did you test it?

locally build with

TARGET_CC="$(brew --prefix)/opt/llvm/bin/clang" just euclid-wasm v1,production

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@srujanchikke srujanchikke added the A-connector-integration Area: Connector integration label Dec 12, 2024
@srujanchikke srujanchikke self-assigned this Dec 12, 2024
@srujanchikke srujanchikke requested a review from a team as a code owner December 12, 2024 16:06
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Dec 12, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/connector_configs/src/connector.rs  39% smaller
  crates/connector_configs/Cargo.toml Unsupported file format
  crates/connector_configs/toml/production.toml Unsupported file format
  crates/connector_configs/toml/sandbox.toml Unsupported file format
  crates/euclid_wasm/Cargo.toml Unsupported file format

@srujanchikke srujanchikke changed the title fix(wasm): fix dependencies for connector configs fix(wasm): fix dependencies for wasm connector configs Dec 12, 2024
@srujanchikke srujanchikke added the C-bug Category: Bug label Dec 12, 2024
@SanchithHegde SanchithHegde changed the title fix(wasm): fix dependencies for wasm connector configs fix(wasm): fix feature dependencies in connector_configs crate for WASM builds Dec 12, 2024
SanchithHegde
SanchithHegde previously approved these changes Dec 12, 2024
View reviewed changes
JeevaRamu0104
JeevaRamu0104 previously approved these changes Dec 13, 2024
View reviewed changes
@srujanchikke srujanchikke requested a review from a team as a code owner December 18, 2024 12:14
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 6eabc82 Dec 23, 2024
21 of 23 checks passed
@Gnanasundari24 Gnanasundari24 deleted the connector_config branch December 23, 2024 14:39
pixincreate added a commit to Ankesh2004/hyperswitch that referenced this pull request Dec 26, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into fix-refacto…
26fa50d 
…r-verifyurl-in-redirection-handler

* 'main' of github.com:juspay/hyperswitch: (444 commits)
  ci: add tests that make use of locker (juspay#6735)
  chore(version): 2024.12.26.1
  fix(router): populate `profile_id` in for the HeaderAuth of v1 (juspay#6936)
  docs(openapi): update /relay request example (juspay#6942)
  chore(version): 2024.12.26.0
  fix(payments_list): handle same payment/attempt ids for different merchants (juspay#6917)
  refactor(core): remove merchant return url from `router_data` (juspay#6895)
  feat(router): add endpoint for listing connector features  (juspay#6612)
  fix(wasm): remove chasenet from jpmorgan wasm as ChaseNet doesn’t exist in PMT (juspay#6927)
  fix(cors): expose all headers set by application in `access-control-expose-headers` header value (juspay#6877)
  chore(version): 2024.12.24.0
  feat(cypress): valdiate `error_code` and `error_message` and make it visible in `reports` (juspay#6913)
  fix(wasm): remove extra space from wasm for payment_method_type of JPMorgan (juspay#6923)
  fix(wasm): fix feature dependencies in `connector_configs` crate for WASM builds  (juspay#6832)
  feat(router): add /retrieve api for relay (juspay#6918)
  feat(core): implemented platform merchant account (juspay#6882)
  feat(payments_v2): add payment method list endpoint (juspay#6805)
  fix(connector): [Cybersource] fix the required fields for wallet mandate payments (juspay#6911)
  chore(version): 2024.12.23.0
  feat(connector): [JPMORGAN] add Payment flows for cards (juspay#6668)
  ...
pixincreate added a commit to Ankesh2004/hyperswitch that referenced this pull request Dec 26, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into fix-refacto…
62bce3b 
…r-verifyurl-in-redirection-handler

* 'main' of github.com:juspay/hyperswitch: (444 commits)
  ci: add tests that make use of locker (juspay#6735)
  chore(version): 2024.12.26.1
  fix(router): populate `profile_id` in for the HeaderAuth of v1 (juspay#6936)
  docs(openapi): update /relay request example (juspay#6942)
  chore(version): 2024.12.26.0
  fix(payments_list): handle same payment/attempt ids for different merchants (juspay#6917)
  refactor(core): remove merchant return url from `router_data` (juspay#6895)
  feat(router): add endpoint for listing connector features  (juspay#6612)
  fix(wasm): remove chasenet from jpmorgan wasm as ChaseNet doesn’t exist in PMT (juspay#6927)
  fix(cors): expose all headers set by application in `access-control-expose-headers` header value (juspay#6877)
  chore(version): 2024.12.24.0
  feat(cypress): valdiate `error_code` and `error_message` and make it visible in `reports` (juspay#6913)
  fix(wasm): remove extra space from wasm for payment_method_type of JPMorgan (juspay#6923)
  fix(wasm): fix feature dependencies in `connector_configs` crate for WASM builds  (juspay#6832)
  feat(router): add /retrieve api for relay (juspay#6918)
  feat(core): implemented platform merchant account (juspay#6882)
  feat(payments_v2): add payment method list endpoint (juspay#6805)
  fix(connector): [Cybersource] fix the required fields for wallet mandate payments (juspay#6911)
  chore(version): 2024.12.23.0
  feat(connector): [JPMORGAN] add Payment flows for cards (juspay#6668)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@Chethan-rao Chethan-rao Chethan-rao approved these changes

@prajjwalkumar17 prajjwalkumar17 prajjwalkumar17 approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@srujanchikke srujanchikke

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@srujanchikke @SanchithHegde @deepanshu-iiitu @prajjwalkumar17 @Chethan-rao @JeevaRamu0104 @Gnanasundari24