fix(cards): Return a 200 response indicating that a customer is none #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssociated with the payment (guest_customer) in CustomerPaymentMethodsListResponse
SanchithHegde
approved these changes
Feb 23, 2024
vsrivatsa-edinburgh
force-pushed
the
fix/CustomerPaymentMethodsListResponse_404_hotfix
branch
from
e503130 to
d4df8ba
Compare
2 tasks
vsrivatsa-edinburgh
force-pushed
the
fix/CustomerPaymentMethodsListResponse_404_hotfix
branch
from
d4df8ba to
edf2188
Compare
Narayanbhat166
approved these changes
Feb 23, 2024
bernard-eugine
deleted the
fix/CustomerPaymentMethodsListResponse_404_hotfix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Bug Description
CustomerPaymentMethodsListResponse returns 404 when there is no customer tied to a payment
Proposed Behavior
Return a 200 response indicating that a customer is not associated with the payment
Current Behavior
A 404 response with "Customer does not exist in our records" is being returned, although the customer_id is null
PR to the main branch #3773
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippyFixes #3767