feat: added dynamic field rendering for klarna #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2025 14:45
RustProfi
requested review from
seekshiva,
PritishBudhiraja,
ArushKapoorJuspay,
sakksham7 and
aritro2002
as code owners
|
Review changes with |
PritishBudhiraja
added
the
Added Comments - waiting for author
Co-authored-by: Pritish Budhiraja <[email protected]>
Co-authored-by: Pritish Budhiraja <[email protected]>
PritishBudhiraja
previously approved these changes
Jan 8, 2025
PritishBudhiraja
added
Ready for Review
aritro2002
previously approved these changes
Jan 8, 2025
sakksham7
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Hey @RustProfi
Can you please try making the confirm body using dynamic fields body instead of KlarnaRedirectionBody, Also the flow that you have checked is for KlarnaSDK flow please do it using Klarna Redirection flow
RustProfi
dismissed stale reviews from aritro2002 and PritishBudhiraja
via
9a20a4c
Hi @sakksham7, using the dynamic fields body worked out fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
added dynamic field rendering for klarna. Issue 6050
How did you test it?
I have created a Klarna Playground account and configured it as a payment processor in hyperswitch. I was then able to test the entire order process with Klarna.
Checklist
npm run re:build