Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #6181: Added feature Azure Key Vault #126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheVidz
Copy link

@TheVidz TheVidz commented Oct 8, 2024

This is my first pull request to hyperswitch-card-vault under Hacktoberfest, kindly give feedback and review.
Support for Azure Key Vault added for Secrets manager similar to the available AWS KMS, HashiCorp Vault, plaintext.
Closes issue #6181
Created files:

azure_vault/core.rs
azure_vault/implementers.rs
azure_vault.rs

Thank you!

Copy link
Collaborator

@Chethan-rao Chethan-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TheVidz,

Thank you for the PR and congrats on your first pull request to hyperswitch-card-vault. Have left some comments. please address.

Also please test the feature and add screen shots of test cases in the PR description.

src/crypto/secrets_manager/managers/azure_vault/core.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants