Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed invariation violation #55

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

abhijeetvermayash
Copy link

@abhijeetvermayash abhijeetvermayash commented Jun 7, 2024

  • If component is not registered using AppRegistry.registerComponent and reactRootView.startReactApplication is called for that component - then it breaks attaching screen shot for ref.
    before (component not registered) -
    Screenshot_20240606-183548
screen-20240607-140804.mp4

Fix -

  • If component is not registered and reactRootView.startReactApplication is called for that component then it breaks
  • There is no build in function to check which all components are registered.
  • So, Exposed a function from HyperSDKReact notifyAboutRegisterComponent that will append this component name to a HashSet and before calling reactRootView.startReactApplication will check that this component is registered or not.

After (component not Registered )-
https://github.com/juspay/hyper-sdk-react/assets/42650474/90fc3ffa-24b2-46b9-9685-f3b71fc980e7

After (component registered) -
https://github.com/juspay/hyper-sdk-react/assets/42650474/2b9d0bda-06e6-4ca2-974f-da59837278c3

@harshgarg18 harshgarg18 merged commit fe7887c into juspay:main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants