Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): android gradle plugin 8 compatibility #52

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

vikrantnegi
Copy link
Contributor

This is the minimum required change for this module to work on react-native 0.73 which includes android gradle plugin 8

It is backwards compatible with all previous versions of react-native that include android gradle plugin 7 or even 6 and older

android/build.gradle Outdated Show resolved Hide resolved
@nverdhan
Copy link

hey - trying this fix with SDK 34 and RN 0.73,

I keep getting this error when importing import in.juspay.hypersdkreact.HyperSdkReactModule

Expecting qualified name

Does this PR fix the above issue too?

@vikrantnegi
Copy link
Contributor Author

Yes @nverdhan This add the supports for android API level 34 which is required for gradle 8.

@nverdhan
Copy link

nverdhan commented Jun 1, 2024

Okay - this fix isn't working for us.

./gradlew --version

------------------------------------------------------------
Gradle 8.3
------------------------------------------------------------

Build time:   2023-08-17 07:06:47 UTC
Revision:     8afbf24b469158b714b36e84c6f4d4976c86fcd5

Kotlin:       1.9.0
Groovy:       3.0.17
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          18.0.2 (Oracle Corporation 18.0.2+9-61)
OS:           Mac OS X 14.4.1 x86_64

RN version is 0.73.8

===

While the prepaid payment on the app just works well, when we import HyperSdkReactModule in our MainActivity.kt for overriding onRequestPermissionsResult, it doesn't recognise the package and asks for a fully qualified name.

import in.juspay.hypersdkreact.HyperSdkReactModule // this line doesn't work shows error "Expecting qualified name"

@harshgarg18 harshgarg18 merged commit e27594a into juspay:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants