Add pingdom_min_request_limit internal metric
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruru-m07
approved these changes
Apr 24, 2024
|
@danielfm pinging you for a review. Obrigado! |
|
One more thing I noticed, I think you need to add docs for the metric in the README. |
danielfm
reviewed
May 5, 2024
danielfm
reviewed
May 5, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
pingdom_min_request_limitinternal metric, which returns the minimal value of reaming requests fromReq-Limit-ShortandReq-Limit-Longheaders. This will allow to monitor the remaining request limit to take action before the API rate limits a token or whole account.