Publish images to github #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfm
reviewed
Jul 27, 2023
|
You're right, i've also removed the |
|
Would this workflow also push the |
|
So as it is now, it only publishes tags and branch names. Would you like me to check how it could also publish 'latest' images on tags or on the master branch? |
danielfm
reviewed
Apr 23, 2024
| MAINTAINER Daniel Martins <[email protected]> | ||
|
|
||
| COPY --from=build /app/bin/pingdom-exporter /pingdom-exporter | ||
| ENTRYPOINT ["/pingdom-exporter"] |
There was a problem hiding this comment.
Not using a multi-stage build here will make the final image much larger than it needs to be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using this exporter in one of our deployments. In commit c9de26f, you mentioned that you're no longer providing the public image. Would you consider publishing this image to the GitHub container registry instead?
Currently, the image is being published in our forked repository.