This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Fix problem with values that contains "=" in --set operation #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidiego
changed the title
guidiego
force-pushed
the
chore/fix-problem-with-eq-in-val
branch
from
42568a1
to
7c1381b
Compare
guidiego
force-pushed
the
chore/fix-problem-with-eq-in-val
branch
from
7c1381b
to
d7ef888
Compare
andersonba
requested review from
felipemsantana,
gabrielpjordao and
ygormutti
ygormutti
approved these changes
Oct 21, 2020
|
|
||
| # Image and tag were overriden but pullPolicy (which is a sibling) wasn't modified | ||
| assert 'bitnami/redis:3.0.7' == get_value(manifest, 'spec/template/spec/containers/0/image') | ||
| assert 'test=' == get_value(manifest, 'spec/template/spec/containers/0/imagePullPolicy') |
There was a problem hiding this comment.
[minor] IMHO this test case repeats too much from the one above. Consider adding an assertion to check other.key equals value-containing-equal-sign= there and removing this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Today we are using Kube Render into Coteminas to create some config values. Unfortunately we use
--setto set a Base64 value that comes with a=at the end of the string.When we apply it to the actual version of kube render it throws this error:
The Fix
To avoid this kind of problem I get the first
=position into the string and did a manually split using array operators :)