Think of dialog to confirm whether to load JupyterLight #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not perfect, in particular theconfirm(...)
is a blocking call, which is not supposed to be used in a OnClik handler as an onclick handler need to respond fast.I think this need to be refactored into utilities functions, and setTimeout(0, callback), and/or Promises.That way the onClick finishes immediately and does not violate the timeout limit.We can't use SetTimeout either as it also suffer the same problem. For now I think we can live with the warning in the console on slow or metered connections.
As noted in the comment, the navigator api is experimental, so it would be good to test properly. In Web Inspector (Firefox and Chome at least), it is possible to artificially throttle the connection to test the logic.