Skip to content

Commit

Permalink
Suggestion: Add pre-commit to format js and css files.
Browse files Browse the repository at this point in the history
I don't believe most of us know the current conventions and have the
tooling installed. So it might be a good thing to have a consistent
style.

If we do this we can also add pre-commit-ci so that PR are automatically
updated. I'm generally not a fan of pre-commit hooks in general and
pre commit-ci as it either can take forcer before you can already
commit, or also when CI push on the PR, prevent pushing before pulling
which can be annoying for contributor. So either choice is good for me.
  • Loading branch information
Carreau committed Feb 13, 2024
1 parent 96f789e commit 62e6953
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
repos:
- repo: https://github.com/pre-commit/mirrors-prettier
rev: 'f12edd9' # Use the sha / tag you want to point at
hooks:
- id: prettier
types_or: [css, javascript]

0 comments on commit 62e6953

Please sign in to comment.