-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins definitions from package.json #16537
Merged
fcollonval
merged 16 commits into
jupyterlab:poc/plugin-data-based
from
fcollonval:ft/plugins-placeholder
Jul 1, 2024
Merged
Plugins definitions from package.json #16537
fcollonval
merged 16 commits into
jupyterlab:poc/plugin-data-based
from
fcollonval:ft/plugins-placeholder
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
pkg:terminal
pkg:notebook
pkg:codeeditor
pkg:console
pkg:filebrowser
pkg:completer
pkg:docregistry
tag:Examples
pkg:inspector
pkg:launcher
pkg:application
pkg:running
pkg:fileeditor
pkg:help
pkg:csvviewer
pkg:imageviewer
pkg:markdownviewer
pkg:rendermime
pkg:tooltip
pkg:services
pkg:apputils
pkg:cells
pkg:codemirror
labels
Jun 30, 2024
fcollonval
force-pushed
the
ft/plugins-placeholder
branch
from
June 30, 2024 16:35
f3ca54e
to
f277467
Compare
fcollonval
merged commit Jul 1, 2024
9cee094
into
jupyterlab:poc/plugin-data-based
28 of 31 checks passed
fcollonval
added a commit
that referenced
this pull request
Aug 1, 2024
* Bump lumino * New plugin registry without changing plugins * Make csvviewer plugins data-based and don't load them * Deactivate widget restoration for csv as it is incompatible with on demand loading. * Fix availablePlugins * Fix license header * Remove FIXME notice not applying any longer * Fix one more github workflow * Fix deduplication * plugin.provides as IToken * Fix integration tests * Fix typo * Comment splice_source test for now * Ensure plugin is activated before testing toolbar * Fix integration test --------- Co-authored-by: Frédéric Collonval <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
pkg:application
pkg:apputils
pkg:attachments
pkg:cell-toolbar
pkg:cells
pkg:celltags
pkg:codeeditor
pkg:codemirror
pkg:completer
pkg:console
pkg:coreutils
pkg:csvviewer
pkg:debugger
pkg:docmanager
pkg:docregistry
pkg:documentsearch
pkg:extensionmanager
pkg:filebrowser
pkg:fileeditor
pkg:help
pkg:htmlviewer
pkg:imageviewer
pkg:inspector
pkg:json
pkg:launcher
pkg:logconsole
pkg:lsp
pkg:mainmenu
pkg:markdownviewer
pkg:mathjax
pkg:mermaid
pkg:metadataform
pkg:notebook
pkg:observables
pkg:outputarea
pkg:pdf
pkg:pluginmanager
pkg:property-inspector
pkg:rendermime
pkg:running
pkg:services
pkg:settingeditor
pkg:settingregistry
pkg:shortcuts
pkg:statedb
pkg:statusbar
pkg:terminal
pkg:toc
pkg:tooltip
pkg:translation
pkg:ui-components
pkg:vega
pkg:workspaces
tag:Examples
tag:Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Part of jupyterlab/lumino#601 for GSoC 2024 project
Code changes
Token.name
matters)User-facing changes
Breaking the restoration of CSV/TSV widgets --> fine at first as this is part of a PoC and much more unknowns have to be addressed.
Backwards-incompatible changes
file://
is a better yarn way of doing that TBC.