Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins definitions from package.json #16537

Merged

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Jun 30, 2024

References

Part of jupyterlab/lumino#601 for GSoC 2024 project

Code changes

  • Bump lumino to use the new feature of providing a custom plugin registry
  • Modify the plugin registry to deal with plugin definition from JSON (Token objects are not used any logger, only the Token.name matters)
  • Make it possible to register a plugin without loading them and only load them at activation.
  • Apply the new plugin definition on the csvviewer-extension
  • Comment out the restoration of widgets for the csvviewer plugins as it is incompatible in its current implementation with the plugin data-based definition.

User-facing changes

Breaking the restoration of CSV/TSV widgets --> fine at first as this is part of a PoC and much more unknowns have to be addressed.

Backwards-incompatible changes

  • the deactivation of plugins may not work as expected as it is impossible to know in advance if a plugin will have a deactivate method implemented.
  • splice source is broken: can we drop it? I think yes as linking through file:// is a better yarn way of doing that TBC.

Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval force-pushed the ft/plugins-placeholder branch from f3ca54e to f277467 Compare June 30, 2024 16:35
@fcollonval fcollonval marked this pull request as ready for review July 1, 2024 15:49
@fcollonval fcollonval merged commit 9cee094 into jupyterlab:poc/plugin-data-based Jul 1, 2024
28 of 31 checks passed
@fcollonval fcollonval deleted the ft/plugins-placeholder branch July 1, 2024 15:49
fcollonval added a commit that referenced this pull request Aug 1, 2024
* Bump lumino

* New plugin registry without changing plugins

* Make csvviewer plugins data-based and don't load them

* Deactivate widget restoration for csv as it is incompatible with on demand loading.

* Fix availablePlugins

* Fix license header

* Remove FIXME notice not applying any longer

* Fix one more github workflow

* Fix deduplication

* plugin.provides as IToken

* Fix integration tests

* Fix typo

* Comment splice_source test for now

* Ensure plugin is activated before testing toolbar

* Fix integration test

---------

Co-authored-by: Frédéric Collonval <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment