Update to Jupyterlab 3.0 #818
Conversation
Updates to rc6 and also increments version number for testing
so tests will run properly in CI
|
note: CI will fail until nbdime PR is merged and released |
There was a problem hiding this comment.
Thanks for starting this @ajbozarth
I push some suggestions to correct the version number to match the current policy.
|
I think we should also turn this into a federated extension to eliminate the build step on installation. I may be wrong but this doesn't currently take that approach? Thoughts on this? (Also hooray! and thanks for tackling this 😄 ) |
I agree, but I believe that initially just updating to 3.0 as a normal extension to be release same day as jupyterlab 3.0 then following up with an update to a federated extension later is the safer option and will cause less delays to users who want to switch to 3.0 |
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
|
recently update the nbdime PR and requested a rc, once an nbdime rc is released I'll update this PR |
|
I've pushed some updates so we can get some review started on this before the nbdime pr is published. Currently the tests are broken and I'm open to others pushing to this PR to address them if you have ideas. As for checking out and running this PR, you will need to also checkout and build the linked nbdime PR and update the package.json here to the relative location of that project on your machine for this to work. |
|
just pushed an update to use the nbdime beta, this PR should now be usable without needing to install a local dev instance of nbdime |
|
Thanks @ajbozarth We are almost there. There is only one fix to figure out why looking into the React tree is not working anymore. Happy to get some help on that one. |
setup.py
Outdated
| @@ -66,7 +66,7 @@ | |||
| long_description_content_type="text/markdown", | |||
| cmdclass=cmdclass, | |||
| packages=setuptools.find_packages(), | |||
| install_requires=["jupyter_server", "nbdime ~=3.0.0b1", "packaging", "pexpect"], | |||
| install_requires=["jupyter_server", "nbdime~=3.0.0b1", "jupyter_packaging~=0.7.9", "packaging", "pexpect"], | |||
There was a problem hiding this comment.
| install_requires=["jupyter_server", "nbdime~=3.0.0b1", "jupyter_packaging~=0.7.9", "packaging", "pexpect"], | |
| install_requires=["jupyter_server", "nbdime~=3.0.0b1", "packaging", "pexpect"], |
jupyter_packaging is not a install dependency but a setup one (only needed by dev'). We should add it to the extra requires - and probably rename it as dev rather than test as there are already other packages like pre-commit or black in there.
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/git-extension-for-jupyterlab-3/7569/2 |
|
@fcollonval @lresende thank you both for helping on this, is this good to merge now? If not what's left blocking it and releasing an rc or beta? |
I'm ok to release a beta. For my information, on the |
It seems to have been accidentally removed in #818
Update to support Jupyterlab 3.0 and addresses any issues accosted with that update.
Currently in draft until final release when this will be updated.
This PR is paired with jupyter/nbdime#551 which is require to test this, including a temporary 1 line hard-coded local import of nbdime
Fixes #779