Use docker push to push image #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker push has a couple of advantages over --push in repo2docker: - It times out sometimes, causing issues where the image just fails to push after building. docker push doesn't have this issue - see 2i2c-org/utoronto-image#20, where we had to manually run a docker push. - docker push provides more useful output than --push This commit also removes some code duplication - we now build the image regardless, and use the flag just to differentiate pushing. An unused bash function was also deleted.
yuvipanda
added a commit
to 2i2c-org/utoronto-image
that referenced
this pull request
Mar 11, 2022
Brings in jupyterhub/repo2docker-action#85, which just uses docker push in upstream r2d-action to fix the timeout issues.
hamelsmu
approved these changes
Mar 11, 2022
|
Tested to work with 2i2c-org/utoronto-image#24 |
|
How do you feel about hitting the merge button, @hamelsmu? :) |
|
Thanks a lot, @hamelsmu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker push has a couple of advantages over --push in
repo2docker:
before pushing! So if an image-test/ fails, the docker image is still
pushed! This is very confusing behavior.
fails to push after building. docker push doesn't have this
issue - see r2d-action broken? 2i2c-org/utoronto-image#20,
where we had to manually run a docker push.
This commit also removes some code duplication - we now build
the image regardless, and use the flag just to differentiate pushing.
An unused bash function was also deleted.