Skip to content

Commit

Permalink
Refer to GGH issue/PR in test_spawner_internal_ssl_secret
Browse files Browse the repository at this point in the history
  • Loading branch information
manics committed Mar 28, 2024
1 parent 2b95b13 commit e75d1cb
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/test_spawner.py
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,10 @@ async def test_spawner_internal_ssl_secret(
ssl_app,
config,
):
"""
Validate that certificates are correctly encoded as base64
https://github.com/jupyterhub/kubespawner/pull/828
"""
spawner = KubeSpawner(
config=config,
user=MockUser(name="ssl"),
Expand All @@ -383,7 +387,6 @@ async def test_spawner_internal_ssl_secret(

spawner.cert_paths = await spawner.move_certs(hub_paths)

# Validate that certificates were correctly encoded as base64
manifest = spawner.get_secret_manifest(None)
for _, secret in manifest.data.items():
base64.b64decode(secret, validate=True)
Expand Down

0 comments on commit e75d1cb

Please sign in to comment.