Make binderhub helm chart not depend on jupyterhub #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update library/docker version from 24.0.2-dind to 24.0.3-dind
binderhub-service image: refreeze requirements.txt
Add ability to pass docker config and included registry credentials to build pods' docker clients, test builds and pushes, and add dockerApi.[extraArgs|extraFiles] to help testing
bugfix: add docker config secret to the deployment to be mounted
…eploy Revert "bugfix: add docker config secret to the deployment to be mounted"
bugfix: fix docker config secret's name used in config
Set the BUILD_NAMESPACE env var to be used by KubernetesBuildExecutor
for more information, see https://pre-commit.ci
Fix docs linkcheck
updates: - [github.com/asottile/pyupgrade: v3.8.0 → v3.10.1](asottile/pyupgrade@v3.8.0...v3.10.1) - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) - [github.com/pre-commit/mirrors-prettier: v3.0.0-alpha.9-for-vscode → v3.0.0](pre-commit/mirrors-prettier@v3.0.0-alpha.9-for-vscode...v3.0.0) - [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0)
…onfig [pre-commit.ci] pre-commit autoupdate
updates: - [github.com/asottile/pyupgrade: v3.17.0 → v3.19.1](asottile/pyupgrade@v3.17.0...v3.19.1) - [github.com/psf/black: 24.8.0 → 25.1.0](psf/black@24.8.0...25.1.0) - [github.com/pycqa/isort: 5.13.2 → 6.0.0](PyCQA/isort@5.13.2...6.0.0)
…config [pre-commit.ci] pre-commit autoupdate
Offboarding myself
…ents binderhub-service image: refreeze requirements.txt
…cies Update library/docker version from 27.0.3-dind to 27.5.1-dind
updates: - [github.com/pycqa/isort: 6.0.0 → 6.0.1](PyCQA/isort@6.0.0...6.0.1) - [github.com/PyCQA/flake8: 7.1.1 → 7.1.2](PyCQA/flake8@7.1.1...7.1.2)
…config [pre-commit.ci] pre-commit autoupdate
…ents binderhub-service image: refreeze requirements.txt
Allow setting extraVolumes and extraVolumeMounts
This was referenced Mar 7, 2025
for more information, see https://pre-commit.ci
It's no longer used, although it hasn't been replaced with anything yet.
|
Opened a topic to discuss paths forward for the spawner mixin: #jupyterhub > Future of binderhub_mixin.py in binderhub |
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Mar 8, 2025
As part of jupyterhub/binderhub#1941, I want to not port imageCleaner to the new chart. Since the image store is not really used to push anymore (since jupyterhub/repo2docker#1421) and we will be able to disregard it completely in the future, we can simply just prune the entire image store than do any complex logic here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP implementation of the proposal that I spoke about with @minrk a while back, and outlined in #1862 (comment).
It basically gets rid of the existing helm chart in this repo which embeds jupyterhub into it, causing all sorts of issues due to the inheritance. We instead want the charts to be composable, so it can be deployed more easily in many different places. This binderhub-service chart was developed thanks to support from GESIS (ty @arnim), and I've merged it in here while preserving all the git history.
I've worked on migrating one of the mybinder.org federation members to using this chart to make sure it works, and 2i2c-bare.mybinder.org now successfully runs on this chart! See jupyterhub/mybinder.org-deploy#3248 for the changes needed
I wanted to work on #1940 as well as using kubernetes buildx support for distributed building, and wanted to unify the helm charts before I do so.
TODO
binderhub-servicetobinderhubBinderHubSpawnerMixin#jupyterhub > Future of binderhub_mixin.py in binderhub