Enable renaming object name from Object Tree #619
Conversation
arjxn-py
force-pushed
the
renaming-objects
branch
from
40cb877 to
381c840
Compare
arjxn-py
changed the title
|
Integration tests report: appsharing.space |
|
Preview PR at appsharing.space |
|
There's a small issue |
|
should the rename input be activated with a single click? And you need to propagate the change to all downstream operators. |
There was a problem hiding this comment.
Thanks a lot for starting this! 🚀
I believe we should tackle #200 first.
| objectName as string | ||
| ); | ||
| if (obj) { | ||
| this.props.cpModel.sharedModel?.updateObjectByName( |
There was a problem hiding this comment.
We not only need to update the specific object, but we also need to go through all objects and see if they depend on it. All objects have a dependency parameter which is a list of object it depends on, by name. And operators are applying their operation based of the objects names.
I believe it's easier to tackle this renaming task once #200 is done. We wouldn't need to do that work I'm describing above because the list of dependencies would be a list of UUIDs. And operators would be defined based of UUIDs.
I would suggest we put this renaming PR on hold while #200 is not tackled.
Thanks @trungleduc |
Shall close #609
rename.mov