Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync editor upon editor change #448

Merged
merged 8 commits into from
Oct 11, 2024
Merged

Sync editor upon editor change #448

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
051fd8d
Sync editor upon editor change
arjxn-py Oct 5, 2024
95576c8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 5, 2024
801b495
Define `syncEditor` not in commands
arjxn-py Oct 8, 2024
0c32b2a
Merge branch 'main' into syncEditor
arjxn-py Oct 8, 2024
021efa3
Implement `_syncEditor` in JupyterCadPanel
arjxn-py Oct 9, 2024
311e706
Emit resize event in `trackerPlugin`
arjxn-py Oct 11, 2024
da03c41
Little cleanup
arjxn-py Oct 11, 2024
4115b79
Merge branch 'main' into syncEditor
arjxn-py Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/base/src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,17 @@ function getSelectedObjectId(widget: JupyterCadWidget): string {
return '';
}

function syncEditor(tracker: WidgetTracker<JupyterCadWidget>) {
tracker.currentChanged.connect(() => {
const currentWidget = tracker.currentWidget;

if (currentWidget) {
const resizeEvent = new Event('resize');
window.dispatchEvent(resizeEvent);
}
});
}

/**
* Add the FreeCAD commands to the application's command registry.
*/
Expand All @@ -683,6 +694,7 @@ export function addCommands(
const trans = translator.load('jupyterlab');
const { commands } = app;
Private.updateFormSchema(formSchemaRegistry);
syncEditor(tracker);

commands.addCommand(CommandIDs.toggleConsole, {
label: trans.__('Toggle console'),
Expand Down
Loading