Update `ThreeJS` #418

arjxn-py · 2024-09-15T19:33:50Z

Currently a draft, but open for reviews
Related to #344

arjxn-py · 2024-09-15T19:45:48Z

The changes doesn't look very pretty at the moment:

We've this plane visible which should be there but not be visible afaik
The colors of the model are a bit dimmed (the set color on the cube is sharp yellow, Maybe a lightning issue?)

Considering this a start, the next thing I plan are -

to get rid of some of @ts-ignores in the mainview
Update threeJS typings maybe
Identify above issues and resolve them

github-actions · 2024-09-15T19:46:25Z

Preview PR at appsharing.space

martinRenou · 2024-09-16T07:06:08Z

Thanks for starting this!

I believe the black mesh we are seeing here is the this._clippingPlaneMesh mesh object from the 3D view. IIRC it is not supposed to be visible, this one should only be used for the filling the gaps when clipping is enabled. I can have a deeper look at this later if you need.

arjxn-py · 2024-09-16T07:37:37Z

I believe the black mesh we are seeing here is the this._clippingPlaneMesh mesh object from the 3D view. IIRC it is not supposed to be visible, this one should only be used for the filling the gaps when clipping is enabled. I can have a deeper look at this later if you need.

yes, i've seen this plane in the mainview. I shall try to look into it and also see if it can be fixed by making it not visible or something. I'll be happy to follow up on the same in case I would need you to have to take a look into the same :)

packages/base/src/3dview/mainview.tsx

github-actions · 2024-09-23T10:23:54Z

Integration tests repot: appsharing.space

martinRenou · 2024-09-26T11:36:06Z

packages/base/src/3dview/mainview.tsx

@@ -218,7 +218,8 @@ export class MainView extends React.Component<IProps, IStates> {

      this._renderer = new THREE.WebGLRenderer({
        alpha: true,
-        antialias: true
+        antialias: true,
+        stencil: true


for more information, see https://pre-commit.ci

packages/base/package.json

for more information, see https://pre-commit.ci

arjxn-py · 2024-09-27T09:39:45Z

Bot please update snapshots.

martinRenou · 2024-09-30T08:33:00Z

Bot please update snapshots!

arjxn-py · 2024-09-30T08:49:09Z

Bot please update snapshots!

Update Galata References workflow is failing everytime xref: #438, I'll be happy to try on to fix it

martinRenou

Thanks a lot! That looks good to me and seems to work well

packages/base/package.json

martinRenou · 2024-09-30T08:43:51Z

packages/base/src/3dview/mainview.tsx

@@ -685,6 +686,7 @@ export class MainView extends React.Component<IProps, IStates> {
      wireframe: this.state.wireframe
    });
    this._clippingPlaneMesh = new THREE.Mesh(planeGeom, planeMat);
+    this._clippingPlaneMesh.visible = this._clipSettings.enabled;


Do we still need this now that we set stencil: true on the renderer?

I'm fine letting this here though, it does sound sensible to not render the plane in anyway when the clipping is disabled.

^^ Just a question, not a blocker

Do we still need this now that we set stencil: true on the renderer?

Yes, it's necessary to be there as it avoids the clip plane mesh from rendering itself fully and renders only the part of the plane which intersect with the geometry.

It avoids this from happening:

Ok then let's keep it! I'm unsure what changed in ThreeJS that requires this change, but the code looks more sensible now so that's good I guess

martinRenou · 2024-09-30T09:02:49Z

Update Galata References workflow is failing everytime xref: #438, I'll be happy to try on to fix it

I commented there. Would you be able to try and fix the bot so we can get this PR green?

arjxn-py · 2024-09-30T09:10:00Z

I commented there. Would you be able to try and fix the bot so we can get this PR green?

Thanks a lot 🚀
Yes, I'm on it.

martinRenou · 2024-09-30T09:34:16Z

Bot please update snapshots!!

martinRenou · 2024-09-30T09:43:17Z

Neat! I'll trigger the CI

martinRenou

Thanks!

arjxn-py added 2 commits September 16, 2024 01:01

Bump ThreeJs to latest version

1873ff5

Also bump three-mesh-bvh to latest

cf9fb51

arjxn-py added the maintenance label Sep 15, 2024

arjxn-py added 2 commits September 16, 2024 16:32

Merge branch 'main' into update-threejs

52caaf9

Remove Redundant plane rendering

1bd0c46

arjxn-py commented Sep 23, 2024

View reviewed changes

packages/base/src/3dview/mainview.tsx Outdated Show resolved Hide resolved

arjxn-py added 5 commits September 25, 2024 16:50

Merge branch 'main' into update-threejs

1354997

Bring back clip plane

3161760

Show _clippingPlaneMesh only if clipping is enabled

1b01646

Complement logic

f8cc8c3

Plane thing fixed

a8ffb20

martinRenou reviewed Sep 26, 2024

View reviewed changes

arjxn-py and others added 2 commits September 26, 2024 17:40

Remove some @ts-ignore statements

73cb1ef

[pre-commit.ci] auto fixes from pre-commit.com hooks

d14a1c1

for more information, see https://pre-commit.ci

martinRenou reviewed Sep 26, 2024

View reviewed changes

packages/base/package.json Show resolved Hide resolved

arjxn-py and others added 3 commits September 26, 2024 20:06

Bump & Add back types/three

883b765

Fix typing failures

7c0c029

[pre-commit.ci] auto fixes from pre-commit.com hooks

b1c311a

for more information, see https://pre-commit.ci

arjxn-py requested review from martinRenou and trungleduc September 27, 2024 11:49

martinRenou reviewed Sep 30, 2024

View reviewed changes

Update Playwright Snapshots

0357b48

martinRenou closed this Sep 30, 2024

martinRenou reopened this Sep 30, 2024

Merge branch 'main' into update-threejs

54aca58

martinRenou approved these changes Sep 30, 2024

View reviewed changes

martinRenou merged commit 0ba9a9e into jupytercad:main Sep 30, 2024
9 checks passed

arjxn-py mentioned this pull request Oct 1, 2024

Update ThreeJS #344

Closed

arjxn-py deleted the update-threejs branch October 2, 2024 05:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `ThreeJS` #418

Update `ThreeJS` #418

arjxn-py commented Sep 15, 2024 •

edited

Loading

arjxn-py commented Sep 15, 2024

github-actions bot commented Sep 15, 2024 •

edited

Loading

martinRenou commented Sep 16, 2024

arjxn-py commented Sep 16, 2024

github-actions bot commented Sep 23, 2024 •

edited

Loading

martinRenou Sep 26, 2024

arjxn-py commented Sep 27, 2024

martinRenou commented Sep 30, 2024

arjxn-py commented Sep 30, 2024

martinRenou left a comment

martinRenou Sep 30, 2024

martinRenou Sep 30, 2024

arjxn-py Sep 30, 2024

martinRenou Sep 30, 2024

martinRenou commented Sep 30, 2024

arjxn-py commented Sep 30, 2024

martinRenou commented Sep 30, 2024

martinRenou commented Sep 30, 2024

martinRenou left a comment

Update ThreeJS #418

Update ThreeJS #418

Conversation

arjxn-py commented Sep 15, 2024 • edited Loading

arjxn-py commented Sep 15, 2024

github-actions bot commented Sep 15, 2024 • edited Loading

martinRenou commented Sep 16, 2024

arjxn-py commented Sep 16, 2024

github-actions bot commented Sep 23, 2024 • edited Loading

martinRenou Sep 26, 2024

Choose a reason for hiding this comment

arjxn-py commented Sep 27, 2024

martinRenou commented Sep 30, 2024

arjxn-py commented Sep 30, 2024

martinRenou left a comment

Choose a reason for hiding this comment

martinRenou Sep 30, 2024

Choose a reason for hiding this comment

martinRenou Sep 30, 2024

Choose a reason for hiding this comment

arjxn-py Sep 30, 2024

Choose a reason for hiding this comment

martinRenou Sep 30, 2024

Choose a reason for hiding this comment

martinRenou commented Sep 30, 2024

arjxn-py commented Sep 30, 2024

martinRenou commented Sep 30, 2024

martinRenou commented Sep 30, 2024

martinRenou left a comment

Choose a reason for hiding this comment

Update `ThreeJS` #418

Update `ThreeJS` #418

arjxn-py commented Sep 15, 2024 •

edited

Loading

github-actions bot commented Sep 15, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading