Sync editor upon editor change

[arjxn-py]

Should close #450

[github-actions]

Integration tests repot: appsharing.space

[github-actions]

Preview PR at appsharing.space

[martinRenou]

Neat!

I don't quite like that this lives under commands.ts though. I'd suggest we put this code somewhere in the JupyterCadPanel class (under packages/base/src/widget.ts)

[trungleduc]

I agree with @martinRenou

[arjxn-py]

Thanks both for suggesting this, i hope I did it alrighty in 801b495

[martinRenou]

With your recent changes you are still calling this logic in commands.ts which should not responsible for this IMO. I'd suggest doing this in the JupyterCadPanel class implementation, maybe in the constructor.

This may be a bit more involved as you'd need for the tracker to be an option for the JupyterCadPanel constructor, but I believe it's the way to go.

This way the JupyterCadPanel is responsible for resizing itself when the context changes. commands.ts is merely a place to define our commands.

[arjxn-py]

Thanks for the comprehensive explanation Martin. This sounds good, i'll be on it.

[martinRenou]

Neat! I just have a final suggestion

[trungleduc]

Thanks!

[SylvainCorlay]

Ah weird, the merge commit does not pass the integration tests.

[arjxn-py]

Ah weird, the merge commit does not pass the integration tests.

Yes, should be related to #471