Make viewHelperDiv a class property

jupytercad · Oct 14, 2024 · bdf1aff · bdf1aff
1 parent 049220a
commit bdf1aff
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 22 deletions.
diff --git a/packages/base/src/3dview/mainview.tsx b/packages/base/src/3dview/mainview.tsx
@@ -362,29 +362,29 @@ export class MainView extends React.Component<IProps, IStates> {
 
       this._transformControls.enabled = false;
       this._transformControls.visible = false;
+      this._createViewHelper();
+    }
+  };
 
-      // ViewHelper setup
-      this._viewHelper = new ViewHelper(
-        this._camera,
-        this._renderer.domElement
-      );
-      this._viewHelper.center = this._controls.target;
+  private _createViewHelper() {
+    this._viewHelper = new ViewHelper(this._camera, this._renderer.domElement);
+    this._viewHelper.center = this._controls.target;
 
-      const viewHelperDiv = document.createElement('div');
-      viewHelperDiv.id = 'viewHelper';
-      viewHelperDiv.style.position = 'absolute';
-      viewHelperDiv.style.right = '0px';
-      viewHelperDiv.style.bottom = '0px';
-      viewHelperDiv.style.height = '128px';
-      viewHelperDiv.style.width = '128px';
+    const viewHelperDiv = document.createElement('div');
+    viewHelperDiv.style.position = 'absolute';
+    viewHelperDiv.style.right = '0px';
+    viewHelperDiv.style.bottom = '0px';
+    viewHelperDiv.style.height = '128px';
+    viewHelperDiv.style.width = '128px';
 
-      this.divRef.current.appendChild(viewHelperDiv);
+    this._viewHelperDiv = viewHelperDiv;
 
-      viewHelperDiv.addEventListener('pointerup', event =>
-        this._viewHelper.handleClick(event)
-      );
-    }
-  };
+    this.divRef.current?.appendChild(this._viewHelperDiv);
+
+    this._viewHelperDiv.addEventListener('pointerup', event =>
+      this._viewHelper.handleClick(event)
+    );
+  }
 
   animate = (): void => {
     this._requestID = window.requestAnimationFrame(this.animate);
@@ -1312,6 +1312,7 @@ export class MainView extends React.Component<IProps, IStates> {
     }
 
     this._camera.add(this._cameraLight);
+    this._createViewHelper();
 
     this._scene.add(this._camera);
     this._controls.object = this._camera;
@@ -1476,6 +1477,7 @@ export class MainView extends React.Component<IProps, IStates> {
   private _pointer3D: IPointer | null = null;
   private _clock: THREE.Clock;
   private _viewHelper: ViewHelper;
+  private _viewHelperDiv: HTMLDivElement | null = null;
   private _collaboratorPointers: IDict<IPointer>;
   private _pointerGeometry: THREE.SphereGeometry;
   private _contextMenu: ContextMenu;

diff --git a/packages/base/src/panelview/formbuilder.tsx b/packages/base/src/panelview/formbuilder.tsx
@@ -46,7 +46,7 @@ export const LuminoSchemaForm = (
           Widget.detach(widget);
         }
       } catch (e) {
-        console.warn('Exception while detaching Lumino widget.', e);
+        // The widget is destroyed already by React.
       }
     };
   }, [children]);

diff --git a/python/jupytercad_core/src/factory.ts b/python/jupytercad_core/src/factory.ts
@@ -1,9 +1,9 @@
 import { ConsolePanel, IConsoleTracker } from '@jupyterlab/console';
 import {
   JupyterCadModel,
-  IJupyterCadTracker,
   IJCadWorkerRegistry,
-  IJCadExternalCommandRegistry
+  IJCadExternalCommandRegistry,
+  IJupyterCadTracker
 } from '@jupytercad/schema';
 import { ABCWidgetFactory, DocumentRegistry } from '@jupyterlab/docregistry';
 import { CommandRegistry } from '@lumino/commands';

diff --git a/python/jupytercad_core/src/plugin.ts b/python/jupytercad_core/src/plugin.ts
@@ -39,6 +39,14 @@ export const trackerPlugin: JupyterFrontEndPlugin<IJupyterCadTracker> = {
     const tracker = new WidgetTracker<JupyterCadWidget>({
       namespace: NAME_SPACE
     });
+    tracker.currentChanged.connect(() => {
+      const currentWidget = tracker.currentWidget;
+
+      if (currentWidget) {
+        const resizeEvent = new Event('resize');
+        window.dispatchEvent(resizeEvent);
+      }
+    });
     console.log('jupytercad:core:tracker is activated!');
     return tracker;
   }