Merge branch 'main' into fix-viewhelper

jupytercad · Oct 14, 2024 · 599484c · 599484c
2 parents 39f6648 + 7161608
commit 599484c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/packages/base/src/panelview/formbuilder.tsx b/packages/base/src/panelview/formbuilder.tsx
@@ -46,7 +46,7 @@ export const LuminoSchemaForm = (
           Widget.detach(widget);
         }
       } catch (e) {
-        console.warn('Exception while detaching Lumino widget.', e);
+        // The widget is destroyed already by React.
       }
     };
   }, [children]);

diff --git a/python/jupytercad_core/src/factory.ts b/python/jupytercad_core/src/factory.ts
@@ -1,9 +1,9 @@
 import { ConsolePanel, IConsoleTracker } from '@jupyterlab/console';
 import {
   JupyterCadModel,
-  IJupyterCadTracker,
   IJCadWorkerRegistry,
-  IJCadExternalCommandRegistry
+  IJCadExternalCommandRegistry,
+  IJupyterCadTracker
 } from '@jupytercad/schema';
 import { ABCWidgetFactory, DocumentRegistry } from '@jupyterlab/docregistry';
 import { CommandRegistry } from '@lumino/commands';

diff --git a/python/jupytercad_core/src/plugin.ts b/python/jupytercad_core/src/plugin.ts
@@ -39,6 +39,14 @@ export const trackerPlugin: JupyterFrontEndPlugin<IJupyterCadTracker> = {
     const tracker = new WidgetTracker<JupyterCadWidget>({
       namespace: NAME_SPACE
     });
+    tracker.currentChanged.connect(() => {
+      const currentWidget = tracker.currentWidget;
+
+      if (currentWidget) {
+        const resizeEvent = new Event('resize');
+        window.dispatchEvent(resizeEvent);
+      }
+    });
     console.log('jupytercad:core:tracker is activated!');
     return tracker;
   }