Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back freecad #1

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Bring back freecad #1

merged 2 commits into from
Dec 7, 2023

Conversation

trungleduc
Copy link
Member

fc

@trungleduc trungleduc added the enhancement New feature or request label Dec 6, 2023
@trungleduc
Copy link
Member Author

I will re-add UI tests in the follow-up

martinRenou
martinRenou requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

jupytercad_freecad/handlers.py
if backend == "FreeCAD":
fc_installed = True
try:
import freecad # noqa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want freecad as a dependency? In that case this would always work and we don't need the server extension

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, but Freecad is not installable from Pypi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf

martinRenou
martinRenou approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 5987145 into main Dec 7, 2023
5 checks passed
@martinRenou martinRenou deleted the add-freecad branch December 7, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @martinRenou