-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CDN URLs, add option for local libs and SRI attributes #962
Open
kramred
wants to merge
12
commits into
jupyter:main
Choose a base branch
from
kramred:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need someone more familiar with the js dependencies to take a look at this. Also tests indicate there's some an issue with the jinja template now: |
Bumping to 6.0 release |
willingc
added
status:need-maintainer-info
Needs additional techncial information or review
and removed
help wanted
labels
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request is a bunch of stuff that is related and introduces two new options:
--HTMLExporter.use_local_libs=<Bool>
(Default: False)--HTMLExporter.use_sri_attr=<Bool>
(Default: False)This allows you to create html output where resources are loaded from a local folder and/or hashes for the external resources are added within the tag loading the resource.
This (partially) addresses the following issues: #238 #754 #761 #763
The default behaviour is not changed (except for updated versions of the external resources)
Changes/additions
slides.py
still hardcoded)urls.tpl
in thetemplates/html
folderurls.tpl
generates URLs for CDN (as they used to be hardcoded infull.tpl
)urls.tpl
is imported infull.tpl
and depending on the switches the variables are setlibs/
folder relative to your HTML output fileOpen issues
nbconvertapp.py