Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always pass relax_add_props=True when validating #1936

Merged
merged 2 commits into from
Jan 14, 2023
Merged

always pass relax_add_props=True when validating #1936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9326b72
always pass relax_add_props=True when validating
minrk Jan 12, 2023
1ea4be5
remove nbformat warning filters
blink1073 Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions nbconvert/exporters/exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,7 @@ def _init_resources(self, resources):

def _validate_preprocessor(self, nbc, preprocessor):
try:
if not hasattr(validator, "normalize"):
nbformat.validate(nbc, relax_add_props=True)
else:
nbformat.validate(nbc)
nbformat.validate(nbc, relax_add_props=True)
except nbformat.ValidationError:
self.log.error("Notebook is invalid after preprocessor %s", preprocessor)
raise
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,6 @@ testpaths = [
filterwarnings = [
"error",
"ignore:nbconvert.utils.lexers is deprecated as of 5.0:UserWarning",
# Pending https://github.com/jupyter/nbformat/pull/256
"ignore:Passing a schema to Validator.iter_errors is deprecated:DeprecationWarning",
# https://github.com/pyppeteer/pyppeteer/issues/342
"ignore:remove loop argument:DeprecationWarning:websockets",
# https://github.com/mhammond/pywin32/issues/1802
Expand Down