Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cache_ports configurable with default value of False. #956

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

jkitchin
Copy link
Contributor

@jkitchin jkitchin commented Jul 6, 2023

This addresses issue #878 and #955. Suggested by @kevin-bates.

@jkitchin
Copy link
Contributor Author

jkitchin commented Jul 6, 2023

I guess I should have added a label. I don't know what this would be considered, I guess an enhancement?

@kevin-bates kevin-bates added the bug label Jul 6, 2023
@kevin-bates
Copy link
Member

I don't know what this would be considered, I guess an enhancement?

Given the previous discussion a while ago, I view this change as something that should have been part of the original change and have applied the bug label.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @jkitchin

@jkitchin
Copy link
Contributor Author

jkitchin commented Jul 7, 2023

Does anything else need to happen to this?

@kevin-bates
Copy link
Member

We usually give folks a day or two to review. However, the build issue is also unwarranted but I believe it is probably unrelated.

@blink1073 - is the coverage issue due to some external version update or something like that? (Sorry, I haven't been "close" to the repos lately.)

@blink1073
Copy link
Contributor

blink1073 commented Jul 7, 2023

The coverage thing is a weird artifact from switching away from codecov where it seems like coverage isn't honoring relative_files = true in some cases. I've seen this on nbconvert as well.

@blink1073 blink1073 merged commit 6dda5ad into jupyter:main Jul 7, 2023
@blink1073
Copy link
Contributor

I'll cut a new release early next week.

@kevin-bates
Copy link
Member

Thank you Steve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants