Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAST_BUILD] Clean conda env #2055

Closed
wants to merge 12 commits into from

Conversation

mathbunnyru
Copy link
Member

@mathbunnyru mathbunnyru commented Dec 8, 2023

Describe your changes

Introduce the env variable which environment to activate by default.
This makes the custom env recipe smaller.
Also eliminates the problem of double activation in the case of a custom environment (if you call bash a few times, you will get a base, custom, base, custom, base, custom... chain).

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

With this PR we will also be close to not hardcoding PATH.
This should also help custom envs - they will be able not to accidentally consume binaries from base environment.
I don't think I will do it, but if someone wants to, I can explain what to do.

@mathbunnyru mathbunnyru changed the title Clean conda env [FAST_BUILD] Clean conda env Jan 7, 2024
@mathbunnyru
Copy link
Member Author

@yuvipanda @benz0li @consideRatio please tell me, what you think about this.

@mathbunnyru
Copy link
Member Author

I think this creates additional complexity to most users, when they don't use custom environments.
And I haven't seen any complaints / issues with the current implementation of custom environments, so let's close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants