Skip to content

Commit

Permalink
Specify protocol when using host.docker.internal proxy (#2181)
Browse files Browse the repository at this point in the history
  • Loading branch information
@mathbunnyru
mathbunnyru authored Dec 9, 2024
1 parent 976fbab commit 87b37b4
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions tests/base-notebook/test_healthcheck.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,10 @@ def test_healthy(
"env,cmd,user",
[
(
["HTTPS_PROXY=host.docker.internal", "HTTP_PROXY=host.docker.internal"],
[
"HTTPS_PROXY=https://host.docker.internal",
"HTTP_PROXY=http://host.docker.internal",
],
None,
None,
),
Expand All @@ -91,8 +94,8 @@ def test_healthy(
"NB_USER=testuser",
"CHOWN_HOME=1",
"JUPYTER_PORT=8123",
"HTTPS_PROXY=host.docker.internal",
"HTTP_PROXY=host.docker.internal",
"HTTPS_PROXY=https://host.docker.internal",
"HTTP_PROXY=http://host.docker.internal",
],
["start-notebook.py", "--ServerApp.base_url=/test"],
"root",
Expand Down

2 comments on commit 87b37b4

@benz0li
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathbunnyru Happy Holidays!

Keep up the great work on https://github.com/jupyter/docker-stacks. Very much appreciated!

Best, Olivier

@mathbunnyru
Copy link
Member Author

@mathbunnyru mathbunnyru commented on 87b37b4 Dec 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathbunnyru Happy Holidays!

Keep up the great work on https://github.com/jupyter/docker-stacks. Very much appreciated!

Best, Olivier

Thanks, Olivier ❤️

Merry Christmas and Happy Holidays ☺️

Please sign in to comment.