Skip to content

Commit

Permalink
Merge pull request #81 from IsabelParedes/comment
Browse files Browse the repository at this point in the history
Show output after first line comments
  • Loading branch information
JohanMabille authored Jan 2, 2024
2 parents f6e0195 + adacbae commit 3c830a9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The xeus team organizes public video meetings. The schedule for future meetings
To install the xeus-sql dependencies:

```bash
mamba install nlohmann_json xtl cppzmq xeus cpp-tabulate>=1.5 xvega xvega-bindings xproperty jupyterlab soci-core compilers cmake -c conda-forge
mamba install nlohmann_json xtl cppzmq xeus xeus-zmq cpp-tabulate>=1.5 xvega xvega-bindings xproperty jupyterlab soci-core compilers cmake -c conda-forge
```

#### Known issues
Expand Down
7 changes: 4 additions & 3 deletions src/xeus_sql_interpreter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
#endif

namespace xeus_sql
{
{
// implemented at the end of the file
// for better readability
const std::array<std::string, 826> & get_keywords();
Expand Down Expand Up @@ -312,7 +312,8 @@ namespace xeus_sql
if (xv_bindings::case_insentive_equals("SELECT", tokenized_input[0]) ||
xv_bindings::case_insentive_equals("DESC", tokenized_input[0]) ||
xv_bindings::case_insentive_equals("DESCRIBE", tokenized_input[0]) ||
xv_bindings::case_insentive_equals("SHOW", tokenized_input[0]))
xv_bindings::case_insentive_equals("SHOW", tokenized_input[0]) ||
xv_bindings::case_insentive_equals("--", tokenized_input[0]))
{
nl::json data = process_SQL_input(code, xv_sql_df);

Expand Down Expand Up @@ -379,7 +380,7 @@ namespace xeus_sql
{
auto pos = -1;
for(int i=code.size()-1; i>=0; --i)
{
{
if(!is_identifier(code[i]))
{
pos = i;
Expand Down

0 comments on commit 3c830a9

Please sign in to comment.