Added support for xyzservices tile providers as basemaps #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
reviewed
Aug 9, 2021
There was a problem hiding this comment.
This is exactly the kind of PR we were hoping for when we started building xyzservices :):
The missing providers will be added in geopandas/xyzservices#83 and we can cut a release shortly after that if that helps. I am just not sure if Strava works at all.
Thanks a lot for playing with us :).
|
Thanks for doing this! |
|
I have released |
davidbrochart
approved these changes
Aug 13, 2021
martinRenou
reviewed
Aug 13, 2021
Closed
added 4 commits
November 15, 2021 17:20
Signed-off-by: Kharude, Sachin <[email protected]>
Signed-off-by: Kharude, Sachin <[email protected]>
Signed-off-by: Kharude, Sachin <[email protected]>
Signed-off-by: Kharude, Sachin <[email protected]>
martinRenou
force-pushed
the
xyzservices
branch
from
b741cb5 to
abe8d4b
Compare
|
Rebased |
|
Thanks a lot for this PR! The docs don't build, but it's not due to this PR so let's ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kharude, Sachin [email protected]
This PR will resolve #854
I have tested all basemaps.
The below basemaps will not work at the moment as they are not defined in xyzservices providers:
Map(basemap=basemaps.OpenStreetMap.BlackAndWhite, center=center, zoom=zoom)
Map(basemap=basemaps.Gaode.Normal, center=center, zoom=zoom)
Map(basemap=basemaps.Gaode.Satellite, center=center, zoom=zoom)
Map(basemap=basemaps.NASAGIBS.ModisTerraBands721CR, center=center, zoom=zoom)
Map(basemap=basemaps.NASAGIBS.ModisAquaTrueColorCR, center=center, zoom=zoom)
Map(basemap=basemaps.NASAGIBS.ModisAquaBands721CR, center=center, zoom=zoom)
Map(basemap=basemaps.NASAGIBS.ViirsTrueColorCR, center=center, zoom=zoom)
Map(basemap=basemaps.Strava.Ride, center=center, zoom=zoom)
Map(basemap=basemaps.Strava.Run, center=center, zoom=zoom)
Map(basemap=basemaps.Strava.Water, center=center, zoom=zoom)
Map(basemap=basemaps.Strava.Winter, center=center, zoom=zoom)