Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector tile layer opacity and visible #1210

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lint
lopezvoliver committed Jun 25, 2024
commit 30ac4f2af6c3d82e8c7b53f9b323a21d46eda531
2 changes: 1 addition & 1 deletion python/jupyter_leaflet/src/layers/VectorTileLayer.ts
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ export class LeafletVectorTileLayerView extends LeafletLayerView {
...this.get_options(),
};
options['rendererFactory'] = L.canvas.tile;

let x: any = options['vectorTileLayerStyles'];
if (typeof x === 'string') {
try {

Unchanged files with check annotations Beta

await page.notebook.save();
for (let c = 0; c < numCellImages; ++c) {
expect(results[c]).toMatchSnapshot(

Check failure on line 74 in ui-tests/tests/ipyleaflet.test.ts

GitHub Actions / Visual Regression (3.8)

tests/ipyleaflet.test.ts:92:7 › ipyleaflet Visual Regression › Light theme: Check ipyleaflet renders

1) tests/ipyleaflet.test.ts:92:7 › ipyleaflet Visual Regression › Light theme: Check ipyleaflet renders Error: Screenshot comparison failed: 1 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/ipyleaflet/ipyleaflet/ui-tests/tests/ipyleaflet.test.ts-snapshots/light--LayerIndex-ipynb-cell-0-linux.png Received: /home/runner/work/ipyleaflet/ipyleaflet/ui-tests/test-results/tests-ipyleaflet-ipyleaflet-Visual-Regression-Light-theme-Check-ipyleaflet-renders/light--LayerIndex-ipynb-cell-0-actual.png Diff: /home/runner/work/ipyleaflet/ipyleaflet/ui-tests/test-results/tests-ipyleaflet-ipyleaflet-Visual-Regression-Light-theme-Check-ipyleaflet-renders/light--LayerIndex-ipynb-cell-0-diff.png 72 | 73 | for (let c = 0; c < numCellImages; ++c) { > 74 | expect(results[c]).toMatchSnapshot( | ^ 75 | getCaptureImageName(contextPrefix, notebook, c) 76 | ); 77 | } at testCellOutputs (/home/runner/work/ipyleaflet/ipyleaflet/ui-tests/tests/ipyleaflet.test.ts:74:26) at /home/runner/work/ipyleaflet/ipyleaflet/ui-tests/tests/ipyleaflet.test.ts:93:5

Check failure on line 74 in ui-tests/tests/ipyleaflet.test.ts

GitHub Actions / Visual Regression (3.8)

tests/ipyleaflet.test.ts:96:7 › ipyleaflet Visual Regression › Dark theme: Check ipyleaflet renders

2) tests/ipyleaflet.test.ts:96:7 › ipyleaflet Visual Regression › Dark theme: Check ipyleaflet renders Error: Screenshot comparison failed: 1 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/ipyleaflet/ipyleaflet/ui-tests/tests/ipyleaflet.test.ts-snapshots/dark--LayerIndex-ipynb-cell-0-linux.png Received: /home/runner/work/ipyleaflet/ipyleaflet/ui-tests/test-results/tests-ipyleaflet-ipyleaflet-Visual-Regression-Dark-theme-Check-ipyleaflet-renders/dark--LayerIndex-ipynb-cell-0-actual.png Diff: /home/runner/work/ipyleaflet/ipyleaflet/ui-tests/test-results/tests-ipyleaflet-ipyleaflet-Visual-Regression-Dark-theme-Check-ipyleaflet-renders/dark--LayerIndex-ipynb-cell-0-diff.png 72 | 73 | for (let c = 0; c < numCellImages; ++c) { > 74 | expect(results[c]).toMatchSnapshot( | ^ 75 | getCaptureImageName(contextPrefix, notebook, c) 76 | ); 77 | } at testCellOutputs (/home/runner/work/ipyleaflet/ipyleaflet/ui-tests/tests/ipyleaflet.test.ts:74:26) at /home/runner/work/ipyleaflet/ipyleaflet/ui-tests/tests/ipyleaflet.test.ts:97:5
getCaptureImageName(contextPrefix, notebook, c)
);
}