Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curvenote --> MyST 🎉 #64

Merged
merged 1,909 commits into from
Oct 28, 2022
Merged

Curvenote --> MyST 🎉 #64

merged 1,909 commits into from
Oct 28, 2022

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Oct 28, 2022

This is a major push upstream of functionality that has been developed in curvenote over the last three years.

The major functionality added on this push is around pdf export, latex export, intersphinx support, citation support, docx export, and latex templating.

There are no changes to mystjs package beyond a few improvements of bugs to fix around code highlighting, all files are now living in a single git repo.

The changes have been highlighted here:
executablebooks/meta#838

Directly after merging/testing this PR we will add another pass on docs, and issues for immediate next steps to continue cleaning things up.

fwkoch and others added 30 commits September 19, 2022 17:14
Use only SiteConfig type/validation defined in blocks
@rowanc1 rowanc1 self-assigned this Oct 28, 2022
This includes all websites.
@rowanc1 rowanc1 requested a review from fwkoch October 28, 2022 21:10
Copy link
Collaborator

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running this locally:
npm install and npm run build work
npm run tests passes locally
npm run dev builds and watches myst-cli which functions as expected

Looking at the changes added after moving things over from curvenote, no issues stand out...

rowanc1 added a commit to curvenote/curvenote that referenced this pull request Oct 28, 2022
@rowanc1
Copy link
Member Author

rowanc1 commented Oct 28, 2022

Ok I am going to merge this in, as this PR is more about moving homes than actually reviewing the code. Future PRs will be smaller than 1900 commits!

That being said, anyone following along please feel free to continuing commenting on this PR if you have specific feedback about a package/file/etc.

There are many, many things that need to be fixed up, and the project is absolutely in beta (especially the CLI). We are aiming to make rapid progress over the coming weeks and months, and are also aiming to move into a more open process as things become more stable.

Please consider this a start in it's new EBP home! 🚀

@rowanc1 rowanc1 merged commit 503b21a into main Oct 28, 2022
@rowanc1 rowanc1 deleted the feat/curvenote-merge branch October 28, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants