-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add almost-infinite scenario with Clark2Dt dispersal #273
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 15.19% 16.35% +1.16%
==========================================
Files 315 297 -18
Lines 21401 21116 -285
==========================================
+ Hits 3251 3453 +202
+ Misses 18150 17663 -487 ☔ View full report in Codecov by Sentry. |
@NicoFirbas I've now added support for p != 1 and the scenario config now takes a |
Can we add a note stating that the 2Dt tends to Gaussian as p becomes large and tends to Cauchy as p goes to zero? Also could be have the default value for the p parameter be 1?
Done :)
|
@NicoFirbas I've now started merging the Clark2Dt scenario into the AlmostInfinite scenario (though it is not quite done yet - only rectangle sampling areas are supported thus far). You now need to enable the scenario: AlmostInfinite(
sample: Rectangle(x: 0, y: 0, width: 10000, height: 10000),
dispersal: Clark2Dt(shape_u: 150, tail_p: 1.0),
) |
necsim/impls/no-std/src/cogs/origin_sampler/almost_infinite/rectangle.rs
Outdated
Show resolved
Hide resolved
necsim/impls/no-std/src/cogs/dispersal_sampler/almost_infinite_clark2dt.rs
Show resolved
Hide resolved
necsim/impls/no-std/src/cogs/dispersal_sampler/almost_infinite_clark2dt.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small fixes are needed, then it should be good to go
@NicoFirbas The config format has slightly changed again as I've done a final pass over the code changes - it's now: scenario: AlmostInfinite(
sample: Rectangle(origin: (x: 0, y: 0), width: 10000, height: 10000),
dispersal: Clark2Dt(shape_u: 150, tail_p: 1.0),
) |
@NicoFirbas I tried to add you as a co-author of this PR but it seems I used the wrong email address - could you share one that is linked to your GitHub account so that I can fix the commit authorship? |
Hi Juniper. That is strange. To my knowledge the email I have linked to my
github account is this one ***@***.***). It is where I am
receiving all of my email notifications as well.
Nicolás Firbas
https://www.researchgate.net/profile/Nicolas_Firbas
…On Sat, Mar 2, 2024 at 11:28 AM Juniper Tyree ***@***.***> wrote:
@NicoFirbas <https://github.com/NicoFirbas> I tried to add you as a
co-author of this PR but it seems I used the wrong email address - could
you share one that is linked to your GitHub account so that I can fix the
commit authorship?
—
Reply to this email directly, view it on GitHub
<#273 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATJMXQFBJ6JAMZF5GXJNKYDYWGSWLAVCNFSM6AAAAABDP55LB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZUG42TONRZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Does normal dispersal need a correction?Does noise-filtered normal dispersal need a correction?