-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI Job to check generate file changes #438
Add CI Job to check generate file changes #438
Conversation
Thanks, super cool! Now that we run the checks I realize both |
@peterpeterparker another thing is the |
🤞
We can skip generating In any case, I except the new action to detect differences even once we have added didc and candid_extractor. I'll fix those once we reach that point, I can have a look to the initIdentity at the same time. |
In Reasons might failed, I am not sure whether I should commit those.
export declare const init: ({ IDL }: { IDL: IDL }) => IDL.Type[];
|
Good idea. 👍
That's expected, it's a good test for this PR. 😉 |
@cylim I think I fixed the issue:
Following those changes I updated the branch and the CI is green 👍 Before merging the PR, I wanted to ask if you we shouldn't cache the Rust compiled files, WDYT? For example with https://github.com/actions/cache/blob/main/examples.md#rust---cargo |
@peterpeterparker pushed new version of |
I re-run a job and the cache worked well, spare half of the time or something. Let's go, we can always iterate if necessary. Thanks a lot for the improvements and PR! |
Having issues to generate
internet_identity.did
locally, the checks.yml scripts should be fine. PR to test.probably related:
https://github.com/junobuild/juno/blob/f8e20817885f5954c681d18c846777e0bae953b5/scripts/identity.utils.mjs#L32:L35
ref: #338