Skip to content

Issue 3054 avoiding inclusion of the suppressed PreconditionViolation… #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2025

Conversation

BassemElMasry
Copy link
Contributor

@BassemElMasry BassemElMasry commented Mar 31, 2025

…Exception in the stacktrace

Overview

This PR is aimed to resolve the issue described here Issue 3054

Shall we include a test under ParameterizedTestIntegrationTests to ensure that suppressed exceptions are not included? I have tried but could not replicate the exact issue mentioned for static initializer so maybe we can take another approach like violating a specific PreCondition and ensure that the default one under the stream.close is not included in the suppressed exceptions.

I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@marcphilipp
Copy link
Member

Shall we include a test under ParameterizedTestIntegrationTests to ensure that suppressed exceptions are not included? I have tried but could not replicate the exact issue mentioned for static initializer so maybe we can take another approach like violating a specific PreCondition and ensure that the default one under the stream.close is not included in the suppressed exceptions.

I've added a test in cb3d5d6.

@marcphilipp marcphilipp merged commit c1e32b5 into junit-team:main Apr 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterized tests: misleading error if exception was thrown in static initializer
2 participants