-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce extension API for container templates #4315
Conversation
Holy smokes, thanks for your work! I've been waiting for this. Can I help with testing this somehow? |
Sure thing! There will be follow-up work (most importantly #878) but if you could review the code and try using it guided by the docs in this PR, I'd be very interested in your feedback. |
I have two questions about the container templates, hope it's Ok to ask them here
|
We don't currently have plans to support intercepting the entire invocation of a container template which would encompass all of its test methods, nested test classes etc. Instead, we will add new lifecycle methods and extension points, specifically for container templates in #4320.
Thanks for reminding me of that issue! I've changed |
Those should also cover the use case I had in mind, thank you.
You're welcome :D |
As discussed in the team, I'll go ahead and merge this to make it easier to work on #878 next. Feedback is still appreciated, though, even post-merge! |
This is awesome! I was awaiting this feature for a long time! |
You will have to wait until 5.13. However, if you're willing to use a milestone version, we will probably release an 5.13.0-M1 early on to make it easier to try out this new feature and provide feedback. |
Overview
Analogous to
@TestTemplate
on the method level, this PR introduces a class-level@ContainerTemplate
annotation with an accompanyingContainerTemplateInvocationContextProvider
extension API.Resolves #871.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations