Skip to content

Move JFR functionality into junit-platform-launcher #4674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Move JFR functionality into junit-platform-launcher #4674

wants to merge 5 commits into from

Conversation

marcphilipp
Copy link
Member

Overview

Resolves #4579.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp marcphilipp self-assigned this Jun 24, 2025
sormuras
sormuras reviewed Jun 24, 2025
View reviewed changes
junit-platform-launcher/src/main/java/org/junit/platform/launcher/jfr/JfrSupport.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better name: JfrUtil as it is not "supported" as an public API?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed in 2560461

@marcphilipp marcphilipp marked this pull request as ready for review June 24, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sormuras sormuras sormuras approved these changes

Assignees

@marcphilipp marcphilipp

Labels
component: Platform theme: reporting type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discontinue junit-platform-jfr and register listeners programmatically in junit-platform-launcher
2 participants
@marcphilipp @sormuras