Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use glide to handle go dependencies #934

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Conversation

hinshun
Copy link
Contributor

@hinshun hinshun commented Jun 1, 2017

Fix #908

@junegunn junegunn merged commit 7d3575b into junegunn:devel Jun 2, 2017
@junegunn
Copy link
Owner

junegunn commented Jun 2, 2017

Merged, thanks. Note that I updated Makefile again to set up its own GOPATH, since I really like to be able to clone fzf in any directory and build it without having to care about GOPATH.

I also moved the main package and Makefile to the root directory (it was not possible in the past due to the existence of Ruby executable named fzf), and I hope this new layout is more conventional for a Go project.

@hinshun
Copy link
Contributor Author

hinshun commented Jun 2, 2017

Personally, I like to include the vendor directory under version control. Then you can be GOPATH independent and also protect against your dependencies being deleted from github. If you want to also protect against dirty vendor changes, then you can write a unit test that checks the git diff with a fresh glide install.

You can also move glide from a go get ... to an environment setup like apt-get install .... Instructions found here: https://github.com/Masterminds/glide#install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants