Skip to content
This repository has been archived by the owner on Aug 12, 2023. It is now read-only.

Feature/can handle attachment #43

Conversation

FarkasJanos
Copy link

@FarkasJanos FarkasJanos commented Oct 10, 2020

Checklist:

  • I've read the Contributing page.
  • I've created an issue and referenced it here.
  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

Description

Added extra check to detect we got image attachment and we can resize and save that image

How has this been tested?

Tested manually
Current modifications need higher WordPress version

  • wp_get_attachment_image_url since 4.4.0
  • wp_image_editor_supports since 3.5.0

Screenshots

Types of changes

New feature (non-breaking change which adds functionality) #42

@FarkasJanos
Copy link
Author

Maybe i can change the checks, to keep compatiblity with WordPress version 3.0.
What do you think?

@junaidbhura
Copy link
Owner

Thanks for the pull request @FarkasJanos ! Let me take a deeper look at this and get back to you!

@JDenne
Copy link

JDenne commented Nov 12, 2020

+1 on this. Thanks @FarkasJanos for your work on this. Look forward to it being merged. We're currently having to check if it's an SVG before using fly so this will be a big help.

@junaidbhura
Copy link
Owner

Hi @FarkasJanos apologies for the delayed response. I had the opportunity to look at this at length today. I've created another PR for this for the following reasons:

  1. This plugin supports WordPress 3.0 and above, and it might break backwards compatibility
  2. Performance reasons

Do you think you could pull this branch down and test if it fixes the issue? #45

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants